Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtnh logo with wiki button and bug report button in the pause menu #1041

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Oct 13, 2024

image

@Dream-Master Dream-Master requested review from a team and mitchej123 October 14, 2024 07:34
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think the idea is good, I don't like the placement. It's asymmetric without embracing it fully. In my opinion, putting these two in a corner would look better and reduce the risk of accidentally clicking on them.
The logo looks totally out of place too. It should either be in the middle between "Game menu" and "Back to Game" or not there at all (I'd prefer not there at all).
Finally, please use an event handler instead of mixins. Mixins may stop working at any moment, e.g. because someone decided it's a good idea to @Overwrite one or more of the methods you inject into. Hopefully this doesn't happen but maybe there'll be a good reason for it. We can't predict the future so it's best to use the intended means.

@Dream-Master Dream-Master requested a review from a team October 18, 2024 07:22
@Dream-Master Dream-Master merged commit c756ebd into master Oct 18, 2024
4 checks passed
@Dream-Master Dream-Master deleted the gtnh-pause-menu branch October 18, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants